Rename localhost to 127.0.0.1 #9
Conversation
There was a problem hiding this comment.
I think changing identifiers might break some pipelines in development using those exact config files.
Also, shouldn't the other two configurations also be altered?
- https://github.com/TREEcg/LDES-Solid-Server/blob/master/server/examples/config-ldes-ts.json
- https://github.com/TREEcg/LDES-Solid-Server/blob/master/server/examples/config-ldes-file_locks.json
Furthermore, I don't think the issue itself would be fixed with this PR.
While the database connection would be fixed, the building in windows itself is not (It seems to be componentsjs related).
| @@ -75,7 +75,7 @@ | |||
| "prefix": "default", | |||
| "view": { | |||
| "@type": "MongoSDSView", | |||
| "descriptionId": "http://localhost:3000/ldes/#timestampFragmentation", | |||
| "descriptionId": "http://127.0.0.1:3000/ldes/#timestampFragmentation", | |||
There was a problem hiding this comment.
This is an identifier, so I don't think it makes sense to change it to 127.0.0.1.
| @@ -75,7 +75,7 @@ | |||
| "prefix": "default", | |||
| "view": { | |||
| "@type": "MongoSDSView", | |||
| "descriptionId": "http://localhost:3000/ldes/#timestampFragmentation", | |||
| "descriptionId": "http://127.0.0.1:3000/ldes/#timestampFragmentation", | |||
There was a problem hiding this comment.
Same comment as previous so I don't think it makes sense to change it to 127.0.0.1.
| @@ -88,7 +88,7 @@ | |||
| "prefix": "indexed", | |||
| "view": { | |||
| "@type": "MongoSDSView", | |||
| "descriptionId": "http://localhost:3000/ldes/#timestampFragmentation", | |||
| "descriptionId": "http://127.0.0.1:3000/ldes/#timestampFragmentation", | |||
There was a problem hiding this comment.
Same comment as previous so I don't think it makes sense to change it to 127.0.0.1.
Fix #7