Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prefix issue #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix prefix issue #10

wants to merge 1 commit into from

Conversation

ajuvercr
Copy link
Member

@ajuvercr ajuvercr commented Jun 29, 2023 •
edited
Loading

Add trailing slash this will be filled in by the incoming url.path so fixing the issue.

Fix #8

@ajuvercr
Copy link
Member Author

Fixes #8

@ajuvercr ajuvercr requested a review from woutslabbinck June 29, 2023 08:26
@ajuvercr ajuvercr mentioned this pull request Jun 29, 2023
Open
woutslabbinck
woutslabbinck suggested changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@woutslabbinck woutslabbinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've built this one and then tried to run it with the config-ldes-all.json config.
This requires more testing, cause suddenly no LDESes (that do work with the main branch) work anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woutslabbinck woutslabbinck woutslabbinck requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prefix View breaks when one prefix is the prefix of another
2 participants
@ajuvercr @woutslabbinck