Add colorization of events #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @DarienFord , thx for the pull-request, I appreciate it! Would it be an option to have it as an option in the config and that you can specify the colors? As I only use one calendar, for me it doesn't bring any value. So, happy to add it, if it would be configurable however. |
iantrich
reviewed
Sep 22, 2018
| <div class="event-wrapper"> | ||
| <div class="event"> | ||
| <div class="event-wrapper" style="border:2px solid ${event.color}"> | ||
| <div class="event" > | ||
| <div class="info"> | ||
| <div class="summary">${event.title}</div> |
There was a problem hiding this comment.
What about instead of doing a border, we do something like this:
<div class="summary">${event.title}<span style="color: ${event.color};"> ●</span></div>
There was a problem hiding this comment.
Gives a small indication of the calendar it is on and is more in line with what you see on proper Google Calendar
There was a problem hiding this comment.
And to @rdehuyss wanting this to be configurable, we can use this:
<div class="summary">${event.title}
${this.config.showColors ? `<span style="color: ${event.color};"> ●</span>` : ''}
</div>
Adding showColors: false to this.config within setConfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a colored border around each event based on the calendar it comes from.
This gives a little more context when dealing with multiple calendars (I have 5).