Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Bug ] Elder power play #19

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

238SAMIxD
Copy link
Contributor

Is your feature request related to a problem? Please describe.
There was a bug while showing power play.
image

Describe the solution you'd like
Properly display dragon icon as well as make text more accessible.

Describe alternatives you've considered
Manually changing images.

Additional context
image
image

@238SAMIxD 238SAMIxD changed the title [BUG] Elder power play [ Bug ] Elder power play Oct 2, 2023
@Himyu
Copy link
Contributor

Himyu commented Oct 5, 2023

Looks go to me but still have to test it. As soon as I have done that it will be in the next new version.
Did you account for the possibility that both the baron and the elder are active at the same time?

@238SAMIxD
Copy link
Contributor Author

238SAMIxD commented Oct 5, 2023

Looks go to me but still have to test it. As soon as I have done that it will be in the next new version. Did you account for the possibility that both the baron and the elder are active at the same time?

That's a very good question. To be honest I don't know how it works with baron and elder active at the time but I guess it just overrides and shows the most recent. I could make another placeholder for second event on the different side or under this one in the future.

@Himyu Himyu merged commit 943cac0 into rcv-prod-toolkit:main Nov 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants