Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRB, mentor replacement, rubric, misc. fixes #56

Merged
merged 13 commits into from
Jul 7, 2018

Conversation

kburk1997
Copy link
Member

Resolves Issue: (add GitHub issue number here)
#55, #53, #40, #31
Changes in this pull request:

  • Fix broken CoC links
  • Add NRB documentation
  • Merge in rubric with some slight changes:
    • Fix spelling errors
    • Fix run on sentences in the Code of Conduct Addendum
    • Rename "Addendum - Code of Conduct" to "Citizenship"
  • Add draft mentor replacement policy

@kburk1997 kburk1997 requested review from wdturner and aeksco June 30, 2018 21:56
@kburk1997
Copy link
Member Author

Also --- I'm not sure what to do for the sidebar search, if someone could help me out that'd be great

docs/index.html Outdated
@@ -19,12 +19,17 @@
loadNavbar: false,
maxDepth: 3,
subMaxLevel: 3,
basePath: 'https://raw.githubusercontent.com/rcos/rcos-handbook/master/docs',
//basePath: 'https://raw.githubusercontent.com/rcos/rcos-handbook/master/docs',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! This needs to be uncommented for the site to work in production - but in development you need it commented out - it's pretty annoying :/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Member

@aeksco aeksco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all fantastic work - thank you so much for getting this organized! I'm 100% for merge after the little fix in docs/index.html.

@aeksco
Copy link
Member

aeksco commented Jul 5, 2018

@kburk1997 Sidebar search is a bit odd - haven't got much of a grasp on it myself, but the docs are here if you want to try to tune it a bit more.

@kburk1997 kburk1997 merged commit 48ade89 into rcos:master Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants