Allow existing env vars to be updated #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are required to run the test suite. Having them in `setup.py` makes it easier to get the project running locally. This change also alters the Travis config to call `setup.py` for installation.
Just to make things easier for contributors.
Plus put the config in setup.cfg to make it easy to just run `flake8` locally.
This is useful for applications that want to update their existing env vars. If you use a system like consul-template to provide environment variables, then it's useful to be able to update your application when they change. This change adds a _overwrite param to the read_envfile method, which allows existing env vars to be updated.
codeinthehole
commented
Nov 22, 2016
|
|
||
| Tests | ||
| ----- | ||
| ~~~~~ | ||
|
|
||
| .. image:: https://secure.travis-ci.org/rconradharris/envparse.png?branch=master |
There was a problem hiding this comment.
@rconradharris It doesn't look like this project is configured on travis yet
| @@ -70,6 +71,6 @@ def run_tests(self): | |||
| 'Topic :: Internet :: WWW/HTTP :: Dynamic Content', | |||
| ], | |||
| extras_require={ | |||
| 'testing': ['pytest'], | |||
| 'testing': ['pytest', 'tox', 'flake8', 'coverage'], | |||
There was a problem hiding this comment.
@rconradharris Not sure if this is strictly required given that tox seems to be able to install stuff. I personally find it clearer to have the testing dependencies listed here. I found that after running tox, I still didn't have flake8 installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR also makes a few changes to make it easier for contributors to get started.
Fixes #17