-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API reorg: RholangCrypto, REV, ... #66
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- no more defaultPayment sort of stuff - move pollAt, firstBlockData from loading to proxy - prune obsolete `rclient publish`
- b2h, h2b -> Hex.encode, Hex.decode - Hex<T> -> HexStr<T> - keyPair, verify -> Ed25519.keyPair, Ed25519.verify - firstBlockData -> Block.firstData - makeProxy -> RegistryProxy.makeProxy - blake2b256Hash -> Blake2b256.hash (likewise keccak, sha256) - simplifiedSHA256Hash -> RHOCore.wrapHash(SHA256.hash)
API top level now fits in a short list: - RHOCore - RegistryProxy - RevAddress - Ed25519keyPair - RNode - RholangCrypto - SignDeployment - test doc examples with markdown-doctest - include markdown-doctest with test script - setup config - lint un-ignore pattern - fix README example - add ed25519Verify example - rnodeAPI: - deprecate listenForDataAtPublicName etc. - move unforgeable name manipulation to RHOCore - fix (documented) names of SignDeployment.sign, verify - send: fix error handling logic - proxy: leave rhoCall undocumented - factor out runRholang (WIP) - assets: leave link() undocumented - tests: add flow, lint; import api consistently - export type JsonExt<T>
- RNode: - doDeploy etc. are instance methods, not static - un-document deprecated methods - tweak GRPCAccess type - punt previewPrivateChannels in favor of RHOCore.fromIds - testRNode: fix blockHash test (also in README) - update testProxy for signing; add @flow - docs/config.yml: toward API doc order - only in --serve, not in build yet - Hex: include in docs - un-export SignDeployment - makeProxy, sendCall: move exports out of the way so docs get flow types
JoshOrndorff
approved these changes
Apr 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass locally. Nice design decisions and docs. Worth sharing with the world.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #54, #63, #38