Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API reorg: RholangCrypto, REV, ... #66

Merged
merged 36 commits into from
Apr 16, 2019
Merged

Conversation

dckc
Copy link
Collaborator

@dckc dckc commented Apr 13, 2019

fixes #54, #63, #38

dckc added 29 commits April 8, 2019 17:53
  - no more defaultPayment sort of stuff
  - move pollAt, firstBlockData from loading to proxy
  - prune obsolete `rclient publish`
  - b2h, h2b -> Hex.encode, Hex.decode
    - Hex<T> -> HexStr<T>
  - keyPair, verify -> Ed25519.keyPair, Ed25519.verify
  - firstBlockData -> Block.firstData
  - makeProxy -> RegistryProxy.makeProxy
  - blake2b256Hash -> Blake2b256.hash (likewise keccak, sha256)
    - simplifiedSHA256Hash -> RHOCore.wrapHash(SHA256.hash)
API top level now fits in a short list:

 - RHOCore
 - RegistryProxy
 - RevAddress
 - Ed25519keyPair
 - RNode
 - RholangCrypto
 - SignDeployment

  - test doc examples with markdown-doctest
    - include markdown-doctest with test script
    - setup config
      - lint un-ignore pattern
    - fix README example
    - add ed25519Verify example
  - rnodeAPI:
    - deprecate listenForDataAtPublicName etc.
    - move unforgeable name manipulation to RHOCore
    - fix (documented) names of SignDeployment.sign, verify
    - send: fix error handling logic
  - proxy: leave rhoCall undocumented
  - factor out runRholang (WIP)
  - assets: leave link() undocumented
  - tests: add flow, lint; import api consistently
    - export type JsonExt<T>
@dckc dckc requested a review from JoshOrndorff April 13, 2019 21:03
@dckc dckc changed the base branch from rnode-0.9 to master April 13, 2019 21:04
dckc and others added 7 commits April 14, 2019 08:39
  - RNode:
    - doDeploy etc. are instance methods, not static
    - un-document deprecated methods
    - tweak GRPCAccess type
    - punt previewPrivateChannels in favor of RHOCore.fromIds
    - testRNode: fix blockHash test (also in README)
  - update testProxy for signing; add @flow
  - docs/config.yml: toward API doc order
    - only in --serve, not in build yet
  - Hex: include in docs
    - un-export SignDeployment
  - makeProxy, sendCall: move exports out of the way so docs get flow types
Copy link
Contributor

@JoshOrndorff JoshOrndorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass locally. Nice design decisions and docs. Worth sharing with the world.

@dckc dckc merged commit 494b054 into rchain-community:master Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename h2b, b2h per ethereum dev norms?
2 participants