-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tested examples to API docs #63
Comments
As I start more thorough documentation, some of the warts in the API seem worth fixing. For example, h2b and b2h #54 . I'm not sure I like ethereum norms much better. This is a commit I haven't pushed yet because it doesn't pass the tests: API re-org in preparation for docs
|
I like all those design choices. 👍 |
ok, I've got markdown-doctest working for ed25519verify. It pointed out that the example in the README was out of date. :) |
I changed my mind about the API again. Top level of API TOC now (027aca3) fits in a short list:
I'm inclined to promote the ed25519Verify example up from that function to the RholangCrypto section and weave it into more of a story form. |
I wonder about combining RevAddress and SignDeployment into one thing... about REV transactions. Maybe fold Ed25519keyPair in there too. |
Status by section as of a6dc377:
There are still some rough edges around getting the flow types picked up by the documentation system... But I think this is enough groundwork to finally attack the question of how to use the registry #32 in the I'd like to talk it over with someone... @JoshOrndorff ? |
Examples like this suggest the API is getting too "deep": const aliceAddr = REV.RevAddress.fromPublicKey(Hex.decode(alicePub));
assert.equal(aliceAddr.toString(), '11112cFcjtrjwn7qCDvTLMu5jEvMSBN2qT1sBwQxDP9AyQCVi26xKZ'); Maybe it should be more like... const aliceAddr = REV.address(alicePub).toString(); |
... using https://github.com/Widdershin/markdown-doctest
The text was updated successfully, but these errors were encountered: