Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not handle onLaneScroll after the last page was loaded #526

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Do not handle onLaneScroll after the last page was loaded #526

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2278bf7
Do not handle onLaneScroll after the last page was loaded
masicek May 25, 2023
2996bad
Rename state lastPage to isPageLast
masicek Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/controllers/Lane.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,16 @@ class Lane extends Component {
currentPage: this.props.currentPage,
addCardMode: false,
collapsed: false,
isDraggingOver: false
isDraggingOver: false,
isPageLast: false
}

handleScroll = evt => {
const node = evt.target
const elemScrollPosition = node.scrollHeight - node.scrollTop - node.clientHeight
const {onLaneScroll} = this.props
// In some browsers and/or screen sizes a decimal rest value between 0 and 1 exists, so it should be checked on < 1 instead of < 0
if (elemScrollPosition < 1 && onLaneScroll && !this.state.loading) {
if (elemScrollPosition < 1 && onLaneScroll && !this.state.loading && !this.state.isPageLast) {
const {currentPage} = this.state
this.setState({loading: true})
const nextPage = currentPage + 1
Expand All @@ -38,6 +39,8 @@ class Lane extends Component {
newCards: moreCards,
nextPage: nextPage
})
} else {
this.setState({isPageLast: true});
}
this.setState({loading: false})
})
Expand Down