Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug | onLaneScroll has to be called on scroll down at all zoom levels #458

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

satya-imaginea
Copy link

Would you please release this change? this should fix the 'onLaneScroll callback has not been triggered' issue permanently.

At a certain zoom level we get minimum 1 as the element position. I tried with all zoom levels, hence this fix should trigger onLaneScroll callback properly in screens of different sizes and at different zoom levels.

image

your release will help me a lot with my project, thanks a lot for earlier responses.
@rcdexta @dapi @oliviervanbulck @yashutanna

I think I don't have permission to raise PR to this branch. Would you release this change, this should fix the 'onLaneScroll callback has not been triggered' issue permanently.
@satya-imaginea satya-imaginea requested a review from dapi as a code owner June 25, 2021 04:38
@satya-imaginea satya-imaginea changed the title Update Lane.js Bug | onLaneScroll has to be called on scroll down at alll zoom levels Jun 25, 2021
@satya-imaginea satya-imaginea changed the title Bug | onLaneScroll has to be called on scroll down at alll zoom levels Bug | onLaneScroll has to be called on scroll down at all zoom levels Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant