Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[ATLAS-123]: add denomination conversion apis in currency module #63

Merged
merged 15 commits into from
Feb 1, 2024

Conversation

RgnDunes
Copy link
Collaborator

@RgnDunes RgnDunes commented Feb 1, 2024

Description

This PR adds two new utilities in Currency Module. These are :

  • convertToUpperDenomination
  • convertToLowerDenomination

Changes Made

List the main changes made in this pull request.

Title ---
JIRA link https://razorpay.atlassian.net/browse/ATLAS-123
Slack thread (if any) NA
Product spec NA
Tech spec/One-pager NA
Bundle Size Difference NA
Fixes Issue NA

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change is a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Is your change backward compatible ?
  • Tested on major browsers (Chrome, Firefox, Safari, IE) ?
  • Tested in a consumer application(s) ?

Additional Notes

Any additional information that would be helpful for the reviewer.

Checklist:

  • Add Jira ID(s) in PR title and in the description?
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code is written in TypeScript and follows the coding standards of the project.
  • I have added relevant documentation and updated the README if necessary.
  • My commit messages are clear and follow the project's commit message conventions.
  • Is any external library added?
  • My changes do not introduce any new runtime errors or warnings.
  • All relevant unit tests have been added/updated in my PR for the change.
  • Any Screenshots (mobile & desktop) required for PR? If yes, have you added the respective screenshots ?
  • Any manual dev testing done by you on beta/func environment?
  • Reviewer added (SLA 2 days)

Reviewer Checklist

  • Sufficient QA/Dev-Testing is done with proof (test cases list)
  • Ensure that the change in bundle size falls within the acceptable range.

PR Title Format

Format: <type>: <subject>

Types can be as follows:

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Copy link

changeset-bot bot commented Feb 1, 2024

🦋 Changeset detected

Latest commit: 602719e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/i18nify-js Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This comment has been minimized.

@rzpcibot
Copy link
Contributor

rzpcibot commented Feb 1, 2024

Warnings
⚠️ Your PR has over 600 lines of code additions 😱 . Try to breakup into separate PRs 👍

Bundle Size Report

Files

click to expand/collapse
🟢 No Change 🗑 File Deleted 🆕 New File 📈 Size Increased 👍 Size Reduced
Parsed (kb)
🚦 File Name Base PR Diff %
🟢 cjs/index.js 40.85 40.85 $\textcolor{green}{0}$ 0
🟢 esm/index.js 40.8 40.8 $\textcolor{green}{0}$ 0
🟢 umd/index.js 46.85 46.85 $\textcolor{green}{0}$ 0

Generated by 🚫 dangerJS against 602719e

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f8b1e78) 91.02% compared to head (602719e) 91.11%.

Files Patch % Lines
packages/i18nify-js/src/modules/currency/index.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   91.02%   91.11%   +0.09%     
==========================================
  Files          26       28       +2     
  Lines         245      270      +25     
  Branches       60       64       +4     
==========================================
+ Hits          223      246      +23     
- Misses         22       24       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

This comment has been minimized.

@RgnDunes RgnDunes requested a review from tarun-khanna February 1, 2024 15:12

This comment has been minimized.

packages/i18nify-js/README.md Outdated Show resolved Hide resolved
packages/i18nify-js/README.md Outdated Show resolved Hide resolved
packages/i18nify-js/README.md Outdated Show resolved Hide resolved
@RgnDunes RgnDunes changed the title feat[ATLAS-123]: add currency conversion from lower unit to higher unit apis feat[ATLAS-123]: add denomination conversion apis in currency module Feb 1, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@tarun-khanna tarun-khanna merged commit 41852b9 into master Feb 1, 2024
11 checks passed
@tarun-khanna tarun-khanna deleted the currency-conversion-apis branch February 1, 2024 19:38
Copy link
Contributor

github-actions bot commented Feb 1, 2024

Unit Test Results

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 41852b9. ± Comparison against base commit f8b1e78.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants