-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Mono-repo setup added for i18nify and i18nify plugins #53
Conversation
🦋 Changeset detectedLatest commit: 0f722b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #53 +/- ##
=======================================
Coverage 91.02% 91.02%
=======================================
Files 26 26
Lines 245 245
Branches 60 60
=======================================
Hits 223 223
Misses 22 22 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Bundle Size Report
|
🟢 No Change | 🗑 File Deleted | 🆕 New File | 📈 Size Increased | 👍 Size Reduced |
---|
Parsed (kb) | |||||
---|---|---|---|---|---|
🚦 | File Name | Base | PR | Diff | % |
🟢 | cjs/index.js |
33.53 |
33.53 |
|
0 |
🟢 | esm/index.js |
33.49 |
33.49 |
|
0 |
🟢 | umd/index.js |
37.83 |
37.83 |
|
0 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.DS_Store
remove this binary files
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Unit Test Results0 files 0 suites 0s ⏱️ Results for commit 8154f6c. |
Description
Moved the architecture of the repo to be a mono-repo.
This mono-repo will now include the core js package ( i18nify-js ) and associated framework wrappers as packages (i18nify-react)
How to setup and build i18nify-js and plugins ?
rm -rf node_modules
)yarn install
at the root. This will install node_modules for all packages.yarn build-js
to build i18nify-js package.yarn build-react
to build i18nify-react package.How to run unit tests for i18nify-js ?
i18nify-js
directory.yarn test
How to run playwright tests for i18nify-js ?
i18nify-js
directory.yarn test:browser
Few noteworthy pointers,
i18nify-js
output size in consideration, it doesn't measure the size cost of plugin bundles (i18nify-react).Changes Made
List the main changes made in this pull request.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Additional Notes
Any additional information that would be helpful for the reviewer.
Checklist:
Reviewer Checklist
PR Title Format
Format:
<type>: <subject>
Types can be as follows:
feat
: (new feature for the user, not a new feature for build script)fix
: (bug fix for the user, not a fix to a build script)docs
: (changes to the documentation)style
: (formatting, missing semi colons, etc; no production code change)refactor
: (refactoring production code, eg. renaming a variable)test
: (adding missing tests, refactoring tests; no production code change)chore
: (updating grunt tasks etc; no production code change)