Add advanced bank identifier validation and retrieval methods #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment.
lets add this in some readme file rather than here
Comment on lines
37
to
40
| const ( | ||
| IdentifierTypeSWIFT = "SWIFT" | ||
| IdentifierTypeRoutingNumber = "routing_number" | ||
| IdentifierTypeIFSC = "IFSC" |
There was a problem hiding this comment.
lets keep it consistant across either all upper case or lower snake case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature adds advanced capabilities to handle bank identifiers, such as enhanced validation for existing identifier types and support for custom identifier formats like SWIFT, Routing Numbers, and IFSC codes. It introduces utility functions to retrieve bank details efficiently and improves error messaging for invalid cases.
Proposed solution
The system will ensure precise validation of input identifiers before processing. The changes modularize validation and retrieval logic into reusable functions. For example, introducing utility methods like
IsValidBankIdentifier,GetBankNameFromShortCode,GetDefaultBankIdentifiersFromShortCode, will make the codebase more organized and extensible.Envison - A consumer of the updated library calls IsValidBankIdentifier("MY", "SWIFT", "PHBMMYKLXXX"), and the function returns true if valid, or a descriptive error if not.
Another use case: GetBankNameFromIdentifier("US", "021000021") retrieves the bank name for the routing number directly, streamlining front-end data presentation in payment forms.