Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing dial codes data in i18nify-data [ ROW-408 ] #179

Merged
merged 5 commits into from
Oct 17, 2024
Merged

fix: add missing dial codes data in i18nify-data [ ROW-408 ] #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bd6deaf
fix: add missing fial codes data in i18nify-data
RgnDunes Oct 16, 2024
2cdbc2f
Create lazy-plants-confess.md
RgnDunes Oct 16, 2024
77abb4b
fix: fixed test data -- validated it from Google's libphonenumber
RgnDunes Oct 16, 2024
28f375f
update codecov artifact version
RgnDunes Oct 16, 2024
ebef8ad
update codecov download-artifact version
RgnDunes Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lazy-plants-confess.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@razorpay/i18nify-js": patch
---

fix: add missing dial codes data in i18nify-data
6 changes: 3 additions & 3 deletions .github/workflows/i18nify-js-coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,13 @@ jobs:
working-directory: packages/i18nify-js
run: yarn test
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
with:
fail_ci_if_error: false
verbose: true
- name: Upload Unit Test Results
if: always()
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: Unit Test Results
path: src/coverage/**/*.xml
Expand All @@ -63,7 +63,7 @@ jobs:
if: (success() || failure()) && ${{ needs.check-if-i18nify-js.outputs.modified == 'true' }}
steps:
- name: Download Artifacts
uses: actions/download-artifact@v2
uses: actions/download-artifact@v4
with:
path: artifacts

Expand Down
40 changes: 30 additions & 10 deletions i18nify-data/phone-number/dial-code-to-country/data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,12 @@
"PR",
"TC",
"TT",
"TF",
"VC",
"VG",
"VI"
"SX",
"VI",
"UM"
],
"7": ["RU", "KZ"],
"20": ["EG"],
Expand All @@ -39,10 +42,20 @@
"40": ["RO"],
"41": ["CH"],
"43": ["AT"],
"44": ["GB", "GB-ENG", "GB-NIR", "GB-SCT", "GB-UKM", "GB-WLS"],
"44": [
"GB",
"GB-ENG",
"GB-NIR",
"GB-SCT",
"GB-UKM",
"GB-WLS",
"GG",
"IM",
"JE"
],
"45": ["DK"],
"46": ["SE"],
"47": ["NO"],
"47": ["NO", "BV", "SJ"],
"48": ["PL"],
"49": ["DE"],
"51": ["PE"],
Expand All @@ -54,10 +67,10 @@
"57": ["CO"],
"58": ["VE"],
"60": ["MY"],
"61": ["AU"],
"61": ["AU", "CX", "CC"],
"62": ["ID"],
"63": ["PH"],
"64": ["NZ"],
"64": ["NZ", "PN"],
"65": ["SG"],
"66": ["TH"],
"81": ["JP"],
Expand All @@ -72,7 +85,7 @@
"95": ["MM"],
"98": ["IR"],
"211": ["SS"],
"212": ["MA"],
"212": ["MA", "EH"],
"213": ["DZ"],
"216": ["TN"],
"218": ["LY"],
Expand Down Expand Up @@ -136,7 +149,7 @@
"355": ["AL"],
"356": ["MT"],
"357": ["CY"],
"358": ["FI"],
"358": ["FI", "AX"],
"359": ["BG"],
"370": ["LT"],
"371": ["LV"],
Expand All @@ -158,7 +171,7 @@
"420": ["CZ"],
"421": ["SK"],
"423": ["LI"],
"500": ["FK"],
"500": ["FK", "GS"],
"501": ["BZ"],
"502": ["GT"],
"503": ["SV"],
Expand All @@ -167,7 +180,7 @@
"506": ["CR"],
"507": ["PA"],
"509": ["HT"],
"590": ["MF", "FW"],
"590": ["MF", "FW", "GP", "BL"],
"591": ["BO"],
"592": ["GY"],
"593": ["EC"],
Expand Down Expand Up @@ -223,6 +236,13 @@
"994": ["AZ"],
"995": ["GE"],
"996": ["KG"],
"998": ["UZ"]
"998": ["UZ"],
"672": ["AQ", "NF"],
"246": ["IO"],
"00672": ["HM"],
RgnDunes marked this conversation as resolved.
Show resolved Hide resolved
"596": ["MQ"],
"508": ["PM"],
"690": ["TK"],
"681": ["WF"]
}
}
40 changes: 20 additions & 20 deletions packages/i18nify-js/src/modules/phoneNumber/__tests__/mocks/phoneNumbers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2872,83 +2872,83 @@
"IO": [
{
"PhoneNumber": "+246-387-555-5",
"isValid": false
"isValid": true
},
{
"PhoneNumber": "+246-387-555-7",
"isValid": false
"isValid": true
},
{
"PhoneNumber": "+246-387-555-0",
"isValid": false
"isValid": true
},
{
"PhoneNumber": "+246-387-555-7",
"isValid": false
"isValid": true
},
{
"PhoneNumber": "+246-387-555-6",
"isValid": false
"isValid": true
},
{
"PhoneNumber": "+246-387-555-0",
"isValid": false
"isValid": true
},
{
"PhoneNumber": "+246-387-555-7",
"isValid": false
"isValid": true
},
{
"PhoneNumber": "+246-387-555-0",
"isValid": false
"isValid": true
},
{
"PhoneNumber": "+246-387-555-7",
"isValid": false
"isValid": true
},
{
"PhoneNumber": "+246-387-555-6",
"isValid": false
"isValid": true
},
{
"PhoneNumber": "+246-387-555-5",
"isValid": false
"isValid": true
},
{
"PhoneNumber": "+246-387-555-1",
"isValid": false
"isValid": true
},
{
"PhoneNumber": "+246-387-555-6",
"isValid": false
"isValid": true
},
{
"PhoneNumber": "+246-387-555-1",
"isValid": false
"isValid": true
},
{
"PhoneNumber": "+246-387-555-0",
"isValid": false
"isValid": true
},
{
"PhoneNumber": "+246-387-555-1",
"isValid": false
"isValid": true
},
{
"PhoneNumber": "+246-387-555-1",
"isValid": false
"isValid": true
},
{
"PhoneNumber": "+246-387-555-4",
"isValid": false
"isValid": true
},
{
"PhoneNumber": "+246-387-555-6",
"isValid": false
"isValid": true
},
{
"PhoneNumber": "+246-387-555-1",
"isValid": false
"isValid": true
}
],
"BN": [
Expand Down
Loading