Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return InvalidArgument for OIDC empty state and code #811

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

rsbh
Copy link
Member

@rsbh rsbh commented Nov 5, 2024

No description provided.

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontier ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 5:56am

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11678406608

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 30.828%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/v1beta1/authenticate.go 0 1 0.0%
core/authenticate/service.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
core/authenticate/service.go 1 21.8%
Totals Coverage Status
Change from base Build 11587012635: -0.003%
Covered Lines: 7624
Relevant Lines: 24731

💛 - Coveralls

@anujk14 anujk14 enabled auto-merge (squash) November 5, 2024 06:23
@rsbh rsbh changed the title fix: return InvalidArgument for OIDC invalid state and code fix: return InvalidArgument for OIDC empty state and code Nov 5, 2024
@rsbh rsbh disabled auto-merge November 5, 2024 10:12
@rsbh rsbh enabled auto-merge (squash) November 5, 2024 10:12
@rsbh rsbh disabled auto-merge November 5, 2024 10:13
@rsbh rsbh enabled auto-merge (squash) November 5, 2024 10:13
@rsbh rsbh merged commit 3bd93db into main Nov 5, 2024
7 checks passed
@rsbh rsbh deleted the fix_check_auth_callback_fields branch November 5, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants