Use pretty user names for replies, fix typo, predictable !help ordering #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raylu
reviewed
Mar 31, 2024
utils.py
Outdated
| @@ -22,7 +22,7 @@ | |||
| def help(cmd): | |||
| if cmd.args: # only reply on "!help" | |||
| return | |||
| commands = set(cmd.bot.commands.keys()) | |||
| commands = cmd.bot.commands.keys() | |||
There was a problem hiding this comment.
wait we call commands.remove() down below
There was a problem hiding this comment.
Its still a list, so no problem there?
There was a problem hiding this comment.
ain't no list
>>> a = {}
>>> a.keys().remove()
AttributeError: 'dict_keys' object has no attribute 'remove'There was a problem hiding this comment.
replaced with del commands[name]
There was a problem hiding this comment.
>>> a = {'cow': 'moo'}
>>> c = a.keys()
>>> del c['cow']
TypeError: 'dict_keys' object does not support item deletionThere was a problem hiding this comment.
converting to a list it is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.