Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sms can be longer than 127 characters #24

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Nucc
Copy link

@Nucc Nucc commented Nov 8, 2013

Here is a fix that allows longer sms than 127 characters in >=ruby-1.9.

@crondaemon
Copy link
Collaborator

I would like to merge this pull request, but it should be pass the tests against ruby 1.9 and 2.0. If you can fix the code so it does, I'll merge it.

@christian-s
Copy link

Is there any progress on that issue?

@Nucc
Copy link
Author

Nucc commented Jun 12, 2014

no. I worked on it a little, in Ruby 1.9 force_encoding("binary") is required for each part the of the message, because different encodings can cause exception, but I had no time to prepare a commit for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants