Merge pull request #50 from HubSpot/prevent_interpreter_from_mutating…

…_serialization_object Prevent the interpreter from mutating the serialization object
rawls238 · Feb 17, 2017 · 98d50a3 · 98d50a3
2 parents 7d76eca + 8bab131
commit 98d50a3
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 12 deletions.
diff --git a/bower.json b/bower.json
@@ -1,7 +1,7 @@
 {
   "name": "planout",
   "main": "dist/planout.js",
-  "version": "3.0.0",
+  "version": "3.0.2",
   "homepage": "https://www.github.com/HubSpot/PlanOut.js",
   "author": "Guy Aridor <[email protected]>",
   "description": "A JavaScript port of Facebook's PlanOut Experimentation Framework",

diff --git a/dist/planout.js b/dist/planout.js
@@ -1643,7 +1643,7 @@ return /******/ (function(modules) { // webpackBootstrap
 
 	    _classCallCheck(this, Interpreter);
 
-	    this._serialization = serialization;
+	    this._serialization = (0, _utils2.deepCopy)(serialization);
 	    if (!environment) {
 	      this._env = new _assignment2.default(experimentSalt);
 	    } else {

diff --git a/dist/planout.min.js b/dist/planout.min.js
diff --git a/dist/planout_core_compatible.js b/dist/planout_core_compatible.js
@@ -1643,7 +1643,7 @@ return /******/ (function(modules) { // webpackBootstrap
 
 	    _classCallCheck(this, Interpreter);
 
-	    this._serialization = serialization;
+	    this._serialization = (0, _utils2.deepCopy)(serialization);
 	    if (!environment) {
 	      this._env = new _assignment2.default(experimentSalt);
 	    } else {

diff --git a/dist/planout_core_compatible.min.js b/dist/planout_core_compatible.min.js
diff --git a/es6/interpreter.js b/es6/interpreter.js
@@ -4,7 +4,7 @@ import { shallowCopy, deepCopy, isObject, isArray, map } from "./lib/utils";
 
 class Interpreter {
   constructor(serialization, experimentSalt='global_salt', inputs={}, environment) {
-    this._serialization = serialization;
+    this._serialization = deepCopy(serialization);
     if (!environment) {
       this._env = new Assignment(experimentSalt);
     } else {
@@ -35,7 +35,7 @@ class Interpreter {
       inputVal = defaultVal;
     }
     var envVal = this._env.get(name);
-    if (envVal !== undefined && envVal !== null) { 
+    if (envVal !== undefined && envVal !== null) {
       return envVal;
     }
     return inputVal;

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "planout",
-  "version": "3.0.1",
+  "version": "3.0.2",
   "dependencies": {
     "sha1": "1.1.0",
     "bignumber.js": "2.0.7"