Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] HACS support #5

Closed
fonix232 opened this issue Nov 29, 2023 · 19 comments
Closed

[FR] HACS support #5

fonix232 opened this issue Nov 29, 2023 · 19 comments
Assignees

Comments

@fonix232
Copy link

It would be awesome if you added support for HACS - even as a custom repo.

The only thing that seems to be needed is adding the hacs.json file to the root of the repo, with the following basic content:

{
  "name": "LEDNetWF BLE",
  "content_in_root": true
}

Then the users can add the repo directly to HACS and let it manage versions whenever a release is made.

@8none1
Copy link
Collaborator

8none1 commented Nov 29, 2023

I think this is a great idea. I will be happy to look at this.

@8none1 8none1 self-assigned this Nov 29, 2023
@8none1
Copy link
Collaborator

8none1 commented Nov 29, 2023

I think we need an icon too. Any ideas?

@raulgbcr
Copy link
Owner

Go ahead Will, I am very busy this weeks, but feel free to do anything you want! Will be following up via emails, so feel free to ping me anywhere. Thanks again for all the work!

@8none1
Copy link
Collaborator

8none1 commented Nov 29, 2023

Icon added. I took a free bulb icon and added a colour wheel in Inkscape. Let me know what you think.

@raulgbcr
Copy link
Owner

looks great!

@8none1
Copy link
Collaborator

8none1 commented Nov 30, 2023

PR for brands icon: home-assistant/brands#4939

@fonix232
Copy link
Author

fonix232 commented Dec 1, 2023

FYI @8none1 @raulgbcr you don't need the logo in the brands repo, unless you want the HACS repo to be added to the official list. Adding hacs.json should be enough for users to be able to add it as a third party repo, so IMO that's slightly higher priority.

@8none1
Copy link
Collaborator

8none1 commented Dec 1, 2023

@raulgbcr when you get a moment, can you add some "topics" to the repo as per: https://hacs.xyz/docs/publish/start#topics

@raulgbcr
Copy link
Owner

raulgbcr commented Dec 1, 2023

@raulgbcr when you get a moment, can you add some "topics" to the repo as per: https://hacs.xyz/docs/publish/start#topics

done!

@8none1
Copy link
Collaborator

8none1 commented Dec 4, 2023

Icon PR for HA Brands is merged.
🎉

image

image

@8none1
Copy link
Collaborator

8none1 commented Dec 4, 2023

And HACS validation job passed! 🎉
image

8none1 added a commit that referenced this issue Dec 4, 2023
Add hessfest action as part of HACS.  Helps #5
@8none1
Copy link
Collaborator

8none1 commented Dec 4, 2023

Created hassfest action as per: https://developers.home-assistant.io/blog/2020/04/16/hassfest/

8none1 added a commit that referenced this issue Dec 4, 2023
Sort keys by alphabetical order expect for domain and name which must be at the top.
Required to pass hassfest linting.
Helps #5
@8none1
Copy link
Collaborator

8none1 commented Dec 4, 2023

Hacsfest action passing 🎉
image

@8none1
Copy link
Collaborator

8none1 commented Dec 4, 2023

@raulgbcr In order to have our PR accepted in to HACS we have to cut a new release after the Hacsfest validation checks started passing.

As such, can you cut a new minor release?
(Or, if you're happy for me to do it, I will. I don't know what to do, but I can work it out)

Once the new release is done I have a PR for HACS, and we are done!!

@raulgbcr
Copy link
Owner

raulgbcr commented Dec 4, 2023

Icon PR for HA Brands is merged. 🎉

Thats awesome!!! Thank you again for everything!!

@raulgbcr In order to have our PR accepted in to HACS we have to cut a new release after the Hacsfest validation checks started passing.

As such, can you cut a new minor release? (Or, if you're happy for me to do it, I will. I don't know what to do, but I can work it out)

Once the new release is done I have a PR for HACS, and we are done!!

Done! I believe you should be able to do it too, I just create a tag and upload the file with the lednetwf.zip name (and thank you again in the description for all the work 😄)

@8none1
Copy link
Collaborator

8none1 commented Dec 4, 2023

PR: For inclusion in HACS proper: hacs/default#2208

@raulgbcr
Copy link
Owner

raulgbcr commented Dec 4, 2023

cool! There was a little error with the release zip, zipped the wrong folder, have fixed it now

@8none1
Copy link
Collaborator

8none1 commented Dec 4, 2023

I think we might be waiting a long time for the PR in HACS to merge. There is a backlog of hundreds going back to September. So I'm going to close this issue as the work on our end is, as far as I can tell, completed.

We're in a good state following this work:

  • We have actions set up to do automatic linting
  • The files are laid out in more of a "standard" way (when compared with other hacs repos)
  • We can be added as a custom repo to HACS now (I haven't actually tested this, I need to upgade HA first)

@8none1 8none1 closed this as completed Dec 4, 2023
@8none1
Copy link
Collaborator

8none1 commented Feb 10, 2024

Whoops!

I deleted the forked HACS repo with the main inclusion request before it was merged. I've created another one: hacs/default#2345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants