Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qemux86: update and enhance kas file #112

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

ejoerns
Copy link
Member

@ejoerns ejoerns commented Aug 15, 2024

Just some minor fixes for the kas file..

Assume we have already checked out the layer when having access to the
kas file. So use it as-is.

Signed-off-by: Enrico Jörns <[email protected]>
@ejoerns ejoerns force-pushed the qemux86-kas-update branch from 0bcaa66 to 1892800 Compare August 15, 2024 07:54
@leon-anavi
Copy link
Collaborator

Looks good to me. Just a minor note: refspec has been deprecated since kas version 14 and will eventually be removed. Right now kas-qemu-grub.yml is for version 10 but I think it is worth considering to upgrade it a newer version (like 17).

Should help to better distinguish additionally checked out layers from
meta-rauc-community itself.

Signed-off-by: Enrico Jörns <[email protected]>
Despite config version is 10, kas complains about 'refspec' usage which
is only introduced with version 14:
| WARNING  - Using deprecated refspec for repository "meta-rauc". You should migrate to commit/tag/branch

For master it should be fine to move forward. Thus we just update to the
kas config version 14 that officially introduced 'branch' and switch to
using 'branch' instead of 'refspec.

Signed-off-by: Enrico Jörns <[email protected]>
@ejoerns ejoerns force-pushed the qemux86-kas-update branch from 1892800 to 9947758 Compare August 15, 2024 08:26
@ejoerns
Copy link
Member Author

ejoerns commented Aug 15, 2024

Looks good to me. Just a minor note: refspec has been deprecated since kas version 14 and will eventually be removed. Right now kas-qemu-grub.yml is for version 10 but I think it is worth considering to upgrade it a newer version (like 17).

I wonder why kas complains about keys that are not even valid for the specified config version... I would tend to argue that one should not unnecessarily update to the highest possible version as this would exclude users with older kas version. But I have updated to the version that officially introduces 'branch' now. Thanks for the hint!

@leon-anavi leon-anavi merged commit 3616741 into rauc:master Aug 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants