Replace Guzzle based request/response object with PSR-17 factory #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, I like it! Could you rebase against master please? |
|
Tests failed due to tested php versions. (guzzle requires php ^7.2, nyholm/psr7 ^7.1, diactoros ^7.1) |
|
Are there no factory implementations that support older versions? |
|
psr/http-factory itself requires php 7.0+. For php 7.0 I found only this: https://packagist.org/packages/php-extended/php-http-message-factory-psr17 |
|
Ok. We're likely doing one more release then dropping support for PHP5 and lower versions of 7. I'll circle back to this PR shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation is based on Guzzle PSR-7 implementation. This might lead to have multiple PSR-7 implementation across project (I'm using zend-diactoros in my project). While this is not a big problem, using one implementation across whole project (including libraries) and single request/response factory should make dependency tree smaller.