-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add init methods for utilizing dispatch queues instead of run loops #15
Open
ansel1
wants to merge
16
commits into
rastersize:develop
Choose a base branch
from
safe-net:master
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+122
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* release/1.1.2: (21 commits) Bumb version to 1.1.2. Fix lastEvent not getting set. compatibility shim, runtime checking example, file-level events --------------------------------------------------------------- validate project settings, update to xcode 3.2 Fixed "missing base SDK". Fixed a bug in the CDEventsCallback(...) code which could cause the excludedURLs to be disregarded. Changed the lastEvent property of the CDEvents class to readonly in public and readwrite in private. Fixed a bug in the test app which could cause an exception to be raised. Fixed a lot of small formatting and cross reference errors in the API doc. Fixed a dup symbols bug properly, thanks to Kirk Kerekes. Defined MACOSX_DEPLOYMENT_TARGET to 10.5. Added some Xcode 4 stuff to the git ignore file. Revert "Changed two "const <type> <name>" constants to macros (they caused duplicate symbol linking errors when the header was included more than once for the same product)." Fixed small markdown error. Added still maintained image. Changed two "const <type> <name>" constants to macros (they caused duplicate symbol linking errors when the header was included more than once for the same product). Changed test application to use full CDEvents init method. Fixed missing __weak code mark in the delegate property declaration. Changed the compiler to LLVM 1.5. Marked CDEventsDelegate pointer as a weak pointer (for GC). ... Conflicts: CDEvents.xcodeproj/project.pbxproj
* release/1.2.0: (32 commits) Bump copyright years. Change framework version to 1.2.0. Update podspec to 1.2.0. Add compile time check of ARC and blocks. Update Xcode project. Fix ARC setting in podspec. Add podspec by @dwlnetnl (rastersize#13). Remove link to GitHub messages. Correctly handle path that contains spaces Made CDEvents class create CDEvent objects with file URLs instead of normal URLs (allows easier comparison with NSURL objects returned by eg. NSFileManager) Update README.mdown Fix contributors URL. Change the authors section in the readme. Update readme with link to new website. Ignore "docs" directory. Update readme to reflect online documentation. Add license file. Add script to generate documentation using appledoc. Update the read me to reflect the new changes. Update the test app to be able to use blocks API. ...
btw, I needed this for my own project only because I preferred not to maintain a dedicated thread and run loop for the event delivery. |
I’m looking at doing something similar to this in an updated version of CDEvents so thanks for sharing your code. The project requires OS X 10.6 so I don’t think your code would need any |
1.2.0 - Requires ARC and blocks. Does not support GC. * tag '1.2.0': (32 commits) Bump copyright years. Change framework version to 1.2.0. Update podspec to 1.2.0. Add compile time check of ARC and blocks. Update Xcode project. Fix ARC setting in podspec. Add podspec by @dwlnetnl (rastersize#13). Remove link to GitHub messages. Correctly handle path that contains spaces Made CDEvents class create CDEvent objects with file URLs instead of normal URLs (allows easier comparison with NSURL objects returned by eg. NSFileManager) Update README.mdown Fix contributors URL. Change the authors section in the readme. Update readme with link to new website. Ignore "docs" directory. Update readme to reflect online documentation. Add license file. Add script to generate documentation using appledoc. Update the read me to reflect the new changes. Update the test app to be able to use blocks API. ...
* release/1.2.1: Update podspec to 1.2.1. Change framework version to 1.2.1. Bump copyright year. Don't export flag macros. Fix whitespace. Fix typo: Inpired -> Inspired. Fix typo: wheter -> whether. fixed typo in code example. Fix an issue with the podspec license.
Fix a memory management issue and more. * tag '1.2.1': Make properties explicitly strong. CDEvent should maintain strong references to its properties. Use relative import to allow compiling in other projects.
Conflicts: CDEvents.podspec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOT REALLY READY FOR PRIMETIME!!
Just offering it for thoughts. It's pretty trivial to use dispatch queues vs run loops, so I thought I'd add some alternative init methods to expose the ability. It's pretty hacked though: there are no #defs checking for versions that support GCD, and some duplication, etc. Honestly, I'm very new to ObjC, Cocoa and C, so I'm not very good yet with all the slick macro stuff.