Skip to content

Commit

Permalink
Merge pull request #12 from rarimo/fix/after-review
Browse files Browse the repository at this point in the history
Fix after review
  • Loading branch information
lilbonekit authored Nov 13, 2024
2 parents 8c5b0ab + 6974e00 commit 56611ad
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 21 deletions.
3 changes: 2 additions & 1 deletion src/components/AppAccordion/AppAccordion.scss
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,13 @@
@include respond-above(medium) {
margin-bottom: to-rem(37);
--accordion-title-font-size: #{to-rem(24)};
--accordion-content-font-size: #{to-rem(20)};
--accordion-content-font-size: #{to-rem(18)};
}

.app-accordion__title {
color: var(--accordion-title-color);
font-size: var(--accordion-title-font-size);
font-weight: 600;
}

.app-accordion__line {
Expand Down
34 changes: 19 additions & 15 deletions src/components/ZkRegisterSection/ZkRegisterSection.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { useEffect, useMemo, useState } from 'react';
import { Trans, useTranslation } from 'react-i18next';

import { COMPONENT_NODE_IDS } from '@/const';
import useAppContext from '@/hooks/useAppContext';

import AppAccordion from '../AppAccordion';
import AppButton from '../AppButton';
Expand All @@ -20,6 +21,7 @@ const ZkRegisterSection = () => {
const { t } = useTranslation();
const [activeIndex, setActiveIndex] = useState(0);
const [imageIndex, setImageIndex] = useState(0);
const { isDesktop } = useAppContext();

const accordions = useMemo(
() => [
Expand Down Expand Up @@ -136,21 +138,23 @@ const ZkRegisterSection = () => {
</li>
))}
</ul>
<GlowingCard
className="zk-register-section__image-wrapper"
data-aos="fade-up"
>
{images.map((image, index) => (
<img
key={index}
src={image.src}
alt={image.alt}
className={cn({
visible: index === imageIndex,
})}
/>
))}
</GlowingCard>
{isDesktop && (
<GlowingCard
className="zk-register-section__image-wrapper"
data-aos="fade-up"
>
{images.map((image, index) => (
<img
key={index}
src={image.src}
alt={image.alt}
className={cn({
visible: index === imageIndex,
})}
/>
))}
</GlowingCard>
)}
</div>
</section>
);
Expand Down
5 changes: 1 addition & 4 deletions src/components/ZkRegisterSection/ZkRegisterSection.scss
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,9 @@

.zk-register-section__content {
margin-top: to-rem(32);
min-height: to-rem(420);
display: flex;
flex-direction: column-reverse;
gap: to-rem(32);

@include respond-above(medium) {
min-height: to-rem(420);
margin-top: to-rem(72);
display: grid;
grid-template-columns: 3fr 2fr;
Expand Down
2 changes: 1 addition & 1 deletion src/localization/resources/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
},
"app-footer": {
"description": "An interoperability protocol for the next generation of multi-chain assets & identities",
"logo-text": "Privacy-first (ZK) social protocol",
"logo-text": "Permissionless (ZK) Registries",
"nav-title": "Navigation",
"follow-us-title": "Follow Us",
"discord": "Discord",
Expand Down

0 comments on commit 56611ad

Please sign in to comment.