-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/proofs #1
Conversation
…ipants DB, airdrop amount in api ctx
ADD COLUMN amount TEXT NOT NULL DEFAULT '0urmo'; | ||
|
||
-- +migrate Down | ||
ALTER TABLE participants |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure that we need this? i believe DROP TABLE participants; will drop all columns, including added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it will, but this statements are for cases to rollback for specific "version" of the database, it seems to me that it's a good practice to have such an option.
internal/cli/main.go
Outdated
@@ -53,6 +54,7 @@ func Run(args []string) bool { | |||
switch cmd { | |||
case serviceCmd.FullCommand(): | |||
run(service.Run) | |||
run(func(context.Context, *config.Config) { broadcaster.Run(ctx, cfg) }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just use broadcaster.Run instead of wrapping into additional function
No description provided.