Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy computed properties behaviour #2160

Merged

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Jan 8, 2025

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 86.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.58%. Comparing base (26f094b) to head (27a43b5).
Report is 1 commits behind head on development.

Files with missing lines Patch % Lines
...raits/Core/Component/HandlesComputedProperties.php 25.00% 6 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             development    #2160   +/-   ##
==============================================
  Coverage          90.58%   90.58%           
  Complexity          1992     1992           
==============================================
  Files                207      211    +4     
  Lines               4503     4503           
==============================================
  Hits                4079     4079           
  Misses               424      424           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit f17a0d8 into rappasoft:development Jan 8, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant