Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy & Improve Collapsed Columns Behaviour #2159

Merged

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Jan 8, 2025

This PR:

  • Moves CollapsedColumn related methods into the appropriate Helper/Configuration traits
  • Migrates the Collapsed Column styling methods into an appropriate trait
  • Cleans up the blades for collapsed columns slightly

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 83.90805% with 14 lines in your changes missing coverage. Please review.

Project coverage is 90.31%. Comparing base (940e0ac) to head (8bc411f).

Files with missing lines Patch % Lines
src/Traits/Helpers/CollapsingColumnHelpers.php 89.28% 6 Missing ⚠️
src/Views/Traits/Columns/IsCollapsible.php 33.33% 6 Missing ⚠️
src/LaravelLivewireTablesServiceProvider.php 75.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             development    #2159      +/-   ##
=================================================
- Coverage          90.59%   90.31%   -0.28%     
- Complexity          1980     1992      +12     
=================================================
  Files                208      207       -1     
  Lines               4485     4503      +18     
=================================================
+ Hits                4063     4067       +4     
- Misses               422      436      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit 26f094b into rappasoft:development Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant