Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre v3.1.4 Merge #1579

Merged
merged 6 commits into from
Dec 4, 2023
Merged

Pre v3.1.4 Merge #1579

merged 6 commits into from
Dec 4, 2023

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Dec 4, 2023

Merge for 3.1.4

New Features

Bug Fixes

Tweaks

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

lrljoe and others added 6 commits November 25, 2023 23:26
V3 - Add New Exceptions NoColumnsException,NoSearchableColumnsException,NoSortableColumnsException
Fix footer rendering issue with extra td displayed depending on bulk action statuses
Removed space from config key
* Add AddRowsRetrievedHook, update ChangeLog

---------

Co-authored-by: lrljoe <[email protected]>
* Initial Commit

* Remove CollapsedColumns Config - Not Used

* Add Get Tests for BulkActions TD/TH Attribute Defaults

* Add Defaults

* Add Initial Tests

* Update Changelog

---------

Co-authored-by: lrljoe <[email protected]>
@lrljoe lrljoe changed the title Pre Release Merge Pre v3.1.4 Merge Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (db0689d) 88.99% compared to head (c12ce7c) 89.07%.
Report is 6 commits behind head on master.

Files Patch % Lines
config/livewire-tables.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1579      +/-   ##
============================================
+ Coverage     88.99%   89.07%   +0.07%     
- Complexity     1268     1276       +8     
============================================
  Files            96       96              
  Lines          3008     3030      +22     
============================================
+ Hits           2677     2699      +22     
  Misses          331      331              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit aec86d1 into master Dec 4, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants