[WIP] Add GHA upload workflow to publish packages #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 18, 2024
jakirkham
force-pushed
the
jakirkham/add_gha_upload_wrkfl
branch
from
c7695d9 to
e2cec49
Compare
|
Put a stub for the upload workflow in PR ( #59 ), which is now merged This was needed as Hopefully now we can run CI here to see the upload workflows behavior and further develop it with CI feedback |
jakirkham
force-pushed
the
jakirkham/add_gha_upload_wrkfl
branch
from
e2cec49 to
e7778f7
Compare
…nda-forge-pinning 2024.04.17.16.16.29
Drop branch selection from GitHub Actions builds. That way all branches can build packages equally.
…nda-forge-pinning 2024.04.17.16.16.29
To keep GHA artifacts more manageable (given our upload process will now depend on creating new artifacts regularly), reduce retention from 7 days to 3 days. This should help cleanup artifacts regularly while not being overly burdensome for testing and debugging. Individual PRs can always adjust this parameter and re-render to change if needed.
…nda-forge-pinning 2024.04.17.16.16.29
As RAPIDS has its own upload process that differs from conda-forge in some particular ways, we just disable the conda-forge upload logic altogether in the prior commits. Additional we enable GHA artifact storage. This way preserve the artifacts from the conda-build jobs somehow. There are just preserved on GHA instead of being uploaded to Anaconda.org. Here we add a new workflow to allow RAPIDS to handle uploads itself. This way any upload strategy can be specified. Also if the upload process changes in the future, this workflow can be updated to align with that process. Lastly conda-smithy doesn't touch this custom workflow file, so it will be unaltered by regular conda-smithy re-rendering operations.
jakirkham
force-pushed
the
jakirkham/add_gha_upload_wrkfl
branch
from
e7778f7 to
a12fbf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As RAPIDS has its own upload process that differs from conda-forge in some particular ways, we just disable the conda-forge upload logic altogether. Additional we enable GHA artifact storage. This way preserve the artifacts from the conda-build jobs somehow. There are just preserved on GHA instead of being uploaded to Anaconda.org.
Here we add a new workflow to allow RAPIDS to handle uploads itself. This way any upload strategy can be specified. Also if the upload process changes in the future, this workflow can be updated to align with that process. Lastly conda-smithy doesn't touch this custom workflow file, so it will be unaltered by regular conda-smithy re-rendering operations.