Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CCCL v2.7.0 final tag. #743

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 14, 2025

Description

CCCL is currently pinned to v2.7.0-rc2. Now that a final tag for v2.7.0 is available, we should use that instead.

See diff: NVIDIA/cccl@v2.7.0-rc2...v2.7.0

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@bdice bdice requested a review from a team as a code owner January 14, 2025 16:53
@bdice
Copy link
Contributor Author

bdice commented Jan 14, 2025

From reviewing the diff, I do not anticipate any risk from merging this as-is, without needing to do test PRs for all of RAPIDS. @robertmaynard What do you think?

@bdice bdice self-assigned this Jan 14, 2025
@bdice bdice added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jan 14, 2025
@bdice
Copy link
Contributor Author

bdice commented Jan 16, 2025

I’ll merge this around the same time as the GCC 13 upgrades (#741) so that we only bust the RAPIDS sccache one time.

@bdice bdice added the DO NOT MERGE Hold off on merging; see PR for details label Jan 16, 2025
@PointKernel
Copy link
Member

CCCL just merged a PR that enables progress on relaxed constexpr work in cuDF: NVIDIA/cccl#3382

Could we include that change in this PR as well? I was planning to open a PR to update the CCCL version in rapids-cmake, but I noticed this PR and wanted to check here first.

@bdice
Copy link
Contributor Author

bdice commented Jan 16, 2025

@PointKernel We should move to a stable tag first. Can we defer on a future upgrade until 25.04? CCCL RAPIDS builds are currently failing and may be broken for a bit. We can’t adopt new CCCL versions with confidence until the CCCL RAPIDS CI is fixed.

@PointKernel
Copy link
Member

Can we defer on a future upgrade until 25.04?

Sure, no problem.

@bdice bdice removed the DO NOT MERGE Hold off on merging; see PR for details label Jan 17, 2025
@bdice
Copy link
Contributor Author

bdice commented Jan 17, 2025

/merge

@rapids-bot rapids-bot bot merged commit af4fe43 into rapidsai:branch-25.02 Jan 17, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants