-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix target/source keymapping #402
Fix target/source keymapping #402
Conversation
@thomcom not sure if it's because of this PR or the previous one, but I cannot run the demo locally: Error: Cannot find module '../util/schema.js'
Require stack:
- /opt/rapids/node/modules/demo/api-server/routes/root.js seems like |
Oh yeah, that's extremely important, thanks for the catch. |
Also @trxcllnt this makes me pretty stressed out because I see that we're not running any tests as part of CI/PR approval? |
Co-authored-by: Paul Taylor <[email protected]>
Co-authored-by: Paul Taylor <[email protected]>
Previously, the index value referred to by a graphology graph
edges
list in thesource
andtarget
values was being used to lookupnodes
according to their position in thenodes
array. This is incorrect.This bugfix creates the
key=>index
mapping so thatsource
andtarget
refer to nodes by theirkey
entry, not their list position.This bugfix also moves the default
index.js
execution of@rapidsai/demo-api-server
to port3010
, compatible with the sigma.js demo.Finally this bugfix adds
.setNullMask
after thegetJSONObject
calls, as spurious entries in the nullmask are occurring there since the original merge #392