Update for the batch

rapidsai · Nov 14, 2024 · 353fcbf · 353fcbf
1 parent 2519cc8
commit 353fcbf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/cpp/include/kvikio/batch.hpp b/cpp/include/kvikio/batch.hpp
@@ -118,7 +118,7 @@ class BatchHandle {
     std::vector<CUfileIOParams_t> io_batch_params;
     io_batch_params.reserve(operations.size());
     for (const auto& op : operations) {
-      if (op.file_handle.is_compat_mode_on()) {
+      if (op.file_handle.is_compat_mode_always_on()) {
         throw CUfileException("Cannot submit a FileHandle opened in compatibility mode");
       }
 

diff --git a/cpp/include/kvikio/file_handle.hpp b/cpp/include/kvikio/file_handle.hpp
@@ -661,11 +661,15 @@ class FileHandle {
    * @brief Returns `true` if the compatibility mode has been enabled for this file.
    *
    * Compatibility mode can be explicitly enabled in object creation. The mode is also enabled
-   * automatically, if file cannot be opened with the `O_DIRECT` flag.
+   * automatically, if file cannot be opened with the `O_DIRECT` flag, or if the system does not
+   * meet the requirements for the cuFile library under the `AUTO` compatibility mode.
    *
    * @return compatibility mode state for the object
    */
-  [[nodiscard]] bool is_compat_mode_on() const noexcept { return _compat_mode == CompatMode::ON; }
+  [[nodiscard]] bool is_compat_mode_always_on() const noexcept
+  {
+    return defaults::is_compat_mode_always_on(_compat_mode);
+  }
 };
 
 }  // namespace kvikio