Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid mamba issues with updating envs with pip dependencies #188

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 12, 2023

If pip dependencies are detected in the generated dependency file, this PR changes rapids-make-conda-env to use conda instead of mamba for the env update. This is necessary because of mamba-org/mamba#3059.

I still use mamba when no pip dependencies are present because it is marginally faster at preprocessing metadata outside of the solve.

@vyasr vyasr added the bug Something isn't working label Dec 12, 2023
@vyasr vyasr self-assigned this Dec 12, 2023
@vyasr vyasr merged commit 6c5e6b7 into rapidsai:branch-24.02 Dec 12, 2023
20 checks passed
@vyasr vyasr deleted the fix/conda_env_update branch December 12, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants