Add MSVC 14.37. #171
Merged
Add MSVC 14.37. #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
approved these changes
Nov 6, 2023
|
/ok to test |
|
@miscco Can you send a |
miscco
requested changes
Nov 9, 2023
| @@ -103,9 +103,9 @@ include: | |||
| - {features: [{<<: *cuda_curr_max, <<: *cccl_cuda_opts}, { name: "cl", version: "14.27" }]} # MSVC 2019 | |||
| - {features: [{<<: *cuda_curr_max, <<: *cccl_cuda_opts}, { name: "cl", version: "14.28" }]} # MSVC 2019 | |||
| - {features: [{<<: *cuda_curr_max, <<: *cccl_cuda_opts}, { name: "cl", version: "14.29" }]} # MSVC 2019 | |||
| - {features: [{<<: *cuda_curr_max, <<: *cccl_cuda_opts}, { name: "cl", version: "14.34" }]} # MSVC 2022 | |||
There was a problem hiding this comment.
Why is this removing 19.34 here but leaving it in below?
There was a problem hiding this comment.
Like in the rest of the files? Deleting them from the other files would prevent us from building it locally... If we needed to.
I'm fine with removal.
There was a problem hiding this comment.
I would just leave it in. We do have most other versions still
wmaxey
commented
Nov 9, 2023
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps MSVC 2022 to include 14.37 and drops 14.34.