Update workflows to support new self-hosted runners #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjacobelli
force-pushed
the
test
branch
13 times, most recently
from
94faab8 to
deabafb
Compare
Signed-off-by: Jordan Jacobelli <[email protected]>
Signed-off-by: Jordan Jacobelli <[email protected]>
Signed-off-by: Jordan Jacobelli <[email protected]>
jjacobelli
changed the title
jjacobelli
changed the title
cwharris
approved these changes
Oct 24, 2023
jjacobelli
added a commit
to jjacobelli/devcontainers
that referenced
this pull request
Nov 29, 2023
In rapidsai#164 we changed directories permissions for rootless docker. As we are not using rootless docker anymore, this is not needed. Signed-off-by: Jordan Jacobelli <[email protected]>
jjacobelli
added a commit
that referenced
this pull request
Nov 29, 2023
In #164 we changed directories permissions for rootless docker. As we are not using rootless docker anymore, this is not needed. Signed-off-by: Jordan Jacobelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is required to support the new self-hosted runners:
rapidsaiprefix anymorebuildkitdconfig file to configure this docker mirrordockerdas rootless. This is creating issues with containers using volume binds because the user inside the container is different from the one outside of the container (see Mounting a volume with rootless with always assign ownership to root moby/moby#45919). To workaround this issue, the directories outside the container are owned by a specific group that will be mapped to the group1000inside the container. To use this workaround, the directories must be created with the group write permissionPipeline running on new runners: https://github.com/rapidsai/devcontainers/actions/runs/6615536458?pr=164