Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only remove newly installed llvm packages and not always everything #159

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

miscco
Copy link
Collaborator

@miscco miscco commented Oct 9, 2023

We want to install a unique version of clang-format for our devcontainer

However, the current install script will remove all prior installs of llvm tools of a different version.

Rather than nuking everything we only replace the package we installed

@miscco miscco force-pushed the clang-format-uninstall-fix branch 4 times, most recently from 9068fbe to a8428aa Compare October 16, 2023 08:36
@miscco
Copy link
Collaborator Author

miscco commented Oct 16, 2023

After some tinkering I just try to not remove clang-format alternatives
and switched the install order

@miscco miscco requested a review from trxcllnt October 17, 2023 07:09
@miscco miscco force-pushed the clang-format-uninstall-fix branch from a8428aa to d977f30 Compare October 18, 2023 08:34
@miscco miscco force-pushed the clang-format-uninstall-fix branch from d977f30 to d16d13b Compare October 18, 2023 09:53
@miscco miscco merged commit df54144 into rapidsai:branch-23.12 Oct 18, 2023
183 checks passed
@miscco miscco deleted the clang-format-uninstall-fix branch October 18, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant