-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wheel tests to CI #1416
Merged
Merged
Add wheel tests to CI #1416
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
1166f87
deps(kvikio): add kvikio to CUDA version matrices
gforsyth 05bd3a8
test(wheels): enable wheel tests in CI
gforsyth 07a03c9
chore: add test_wheel script
gforsyth edf038d
chore: add wheel-tests to pr builder workflow
gforsyth 08d0123
chore: chmod +x
gforsyth 680e186
chore: fix wheel name generation
gforsyth b750b47
Apply suggestions from code review
gforsyth 0a43f38
chore: bump copyright to year PR will land
gforsyth 30fddec
chore: build wheels for each arch to be tested
gforsyth 1e20b80
revert: don't build a bunch of pure wheels
gforsyth d11ed17
ci: set PY_WHEEL_PURE in build_wheel so it's discoverable in the tests
gforsyth 3689da8
remove invalid [test] extra
gforsyth 058ed44
generate test dependencies and install in test_wheel.sh
gforsyth a44356a
don't use pytest-xdist for now
gforsyth 14177a8
add wheel tests to workflows
gforsyth e410d1d
combine dep install and wheel install
gforsyth 22a2a69
point at the actual test directory
gforsyth f5ff692
skip ucxx tests
gforsyth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,7 @@ jobs: | |
- conda-python-tests | ||
- docs-build | ||
- wheel-build | ||
- wheel-tests | ||
secrets: inherit | ||
uses: rapidsai/shared-workflows/.github/workflows/[email protected] | ||
checks: | ||
|
@@ -53,3 +54,10 @@ jobs: | |
# This selects "ARCH=amd64 + the latest supported Python + CUDA". | ||
matrix_filter: map(select(.ARCH == "amd64")) | max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))]) | [.] | ||
script: "ci/build_wheel.sh" | ||
wheel-tests: | ||
needs: wheel-build | ||
secrets: inherit | ||
uses: rapidsai/shared-workflows/.github/workflows/[email protected] | ||
with: | ||
build_type: pull-request | ||
script: "ci/test_wheel.sh" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,3 +22,12 @@ jobs: | |
branch: ${{ inputs.branch }} | ||
date: ${{ inputs.date }} | ||
sha: ${{ inputs.sha }} | ||
wheel-tests: | ||
secrets: inherit | ||
uses: rapidsai/shared-workflows/.github/workflows/[email protected] | ||
with: | ||
build_type: nightly | ||
branch: ${{ inputs.branch }} | ||
date: ${{ inputs.date }} | ||
sha: ${{ inputs.sha }} | ||
script: ci/test_wheel.sh |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
#!/bin/bash | ||
# Copyright (c) 2025, NVIDIA CORPORATION. | ||
|
||
set -eou pipefail | ||
|
||
RAPIDS_PY_WHEEL_NAME="dask-cuda" RAPIDS_PY_WHEEL_PURE="1" rapids-download-wheels-from-s3 python ./dist | ||
|
||
# Install cuda-suffixed dependencies b/c while `dask-cuda` has no cuda suffix, the test dependencies do | ||
rapids-dependency-file-generator \ | ||
--output requirements \ | ||
--file-key "test_python" \ | ||
--matrix "cuda=${RAPIDS_CUDA_VERSION%.*};arch=$(arch);py=${RAPIDS_PY_VERSION};cuda_suffixed=true" \ | ||
| tee /tmp/requirements-test.txt | ||
|
||
rapids-logger "Installing test dependencies" | ||
# echo to expand wildcard | ||
python -m pip install -v --prefer-binary -r /tmp/requirements-test.txt $(echo ./dist/dask_cuda*.whl) | ||
|
||
python -m pytest ./dask_cuda/tests -k "not ucxx" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,14 +47,6 @@ files: | |
table: project | ||
includes: | ||
- run_python | ||
py_test: | ||
output: pyproject | ||
pyproject_dir: . | ||
extras: | ||
table: project.optional-dependencies | ||
key: test | ||
includes: | ||
- test_python | ||
py_docs: | ||
output: pyproject | ||
pyproject_dir: . | ||
|
@@ -188,21 +180,21 @@ dependencies: | |
- numactl-devel-cos7-aarch64 | ||
- output_types: [requirements, pyproject] | ||
matrices: | ||
# kvikio should be added to the CUDA-version-specific matrices once there are wheels available | ||
# ref: https://github.com/rapidsai/kvikio/pull/369 | ||
- matrix: | ||
cuda: "12.*" | ||
cuda_suffixed: "true" | ||
packages: | ||
- cudf-cu12==25.2.*,>=0.0.0a0 | ||
- dask-cudf-cu12==25.2.*,>=0.0.0a0 | ||
- kvikio-cu12==25.2.*,>=0.0.0a0 | ||
- ucx-py-cu12==0.42.*,>=0.0.0a0 | ||
- matrix: | ||
cuda: "11.*" | ||
cuda_suffixed: "true" | ||
packages: | ||
- cudf-cu11==25.2.*,>=0.0.0a0 | ||
- dask-cudf-cu11==25.2.*,>=0.0.0a0 | ||
- kvikio-cu11==25.2.*,>=0.0.0a0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oh nice, thank you! |
||
- ucx-py-cu11==0.42.*,>=0.0.0a0 | ||
- matrix: | ||
packages: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok to me... looks like the changes from #1406 doing the same thing in the conda Python test jobs hasn't been reverted yet.