Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put a ceiling on cuda-python #445

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Nov 6, 2024

This project is incompatible with newer versions of cuda-python. This puts ceilings of <=11.8.3 (CUDA 11) and <=12.6.0 (CUDA 12) on that library.

Those ceilings should be removed and replaced with != constraints once new releases of cuda-python are up that this project is compatible with.

See rapidsai/build-planning#116 for more information.

@bdice bdice requested a review from a team as a code owner November 6, 2024 12:38
@bdice bdice requested a review from msarahan November 6, 2024 12:38
@bdice bdice added non-breaking Introduces a non-breaking change bug Something isn't working labels Nov 6, 2024
@github-actions github-actions bot added the Python label Nov 6, 2024
@jameslamb jameslamb requested review from jameslamb and removed request for msarahan November 6, 2024 21:57
@jameslamb
Copy link
Member

The devcontainers pip job (but not the conda one) is failing while compiling tests:

test/CMakeFiles/NEIGHBORS_ANN_IVF_FLAT_TEST.dir/neighbors/ann_ivf_flat/test_int8_t_int64_t.cu.o
  /home/coder/cuvs/cpp/test/neighbors/ann_ivf_flat/../ann_ivf_flat.cuh(352): error: namespace "thrust" has no member "reduce"
             thrust::reduce(raft::resource::get_thrust_policy(handle_), mask.data_handle(), mask.data_handle() + n_elems, 0) == list_size * ps.dim
                     ^
  
  1 error detected in the compilation of "/home/coder/cuvs/cpp/test/neighbors/ann_ivf_flat/test_int8_t_int64_t.cu".

(build link)

Looks to me like that's happening elsewhere too, like in #448 (a recently-opened docs-only PR): (build link)

@jameslamb jameslamb requested a review from a team as a code owner November 6, 2024 23:59
@github-actions github-actions bot added the cpp label Nov 6, 2024
@jameslamb
Copy link
Member

Explicitly including <thrust/reduce.h> everywhere that uses thrust::reduce (1075135) fixed the pip devcontainers build... thanks @davidwendt !

Now we have new errors... all of the amd64 conda-python-build jobs are failing to compile, with errors like this:

      Error compiling Cython file:
      ------------------------------------------------------------
      ...
      # limitations under the License.
      #
      # cython: language_level=3
      
      
      from cuda.ccudart cimport cudaStream_t
      ^
      ------------------------------------------------------------
      
      /opt/conda/conda-bld/work/python/cuvs/cuvs/common/c_api.pxd:19:0: 'cuda/ccudart.pxd' not found

(build link)

Those jobs are all getting the new cuda-python packages, e.g. 12.6.2 for CUDA 12

    cuda-python:                      12.6.2-py310h521d3fa_0                       conda-forge            

The passing arm jobs are getting the older cuda-python packages, e.g. 12.6.0 for CUDA 12

    cuda-python:                      12.6.0-py310hfaf7bc8_2                       conda-forge  

So this incompatibility with the new packages is something we'll need to figure out.

@jameslamb jameslamb changed the title Disallow cuda-python 12.6.1 and 11.8.4 Put a ceiling on cuda-python Nov 7, 2024
rapids-bot bot pushed a commit to rapidsai/rmm that referenced this pull request Nov 7, 2024
Follow-up to #1720

Contributes to rapidsai/build-planning#116

That PR used `!=` requirements to skip a particular version of `cuda-python` that `rmm` was incompatible with. A newer version of `cuda-python` (12.6.2 for CUDA 12, 11.8.5 for CUDA 11) was just released, and it also causes some build issues for RAPIDS libraries: rapidsai/cuvs#445 (comment)

To unblock CI across RAPIDS, this proposes **temporarily** switching to ceilings on `rmm`'s `cuda-python` dependency.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #1723
rapids-bot bot pushed a commit to rapidsai/kvikio that referenced this pull request Nov 7, 2024
Follow-up to #537

Contributes to rapidsai/build-planning#116

That PR used `!=` requirements to skip a particular version of `cuda-python` that `kvikio` was incompatible with. A newer version of `cuda-python` (12.6.2 for CUDA 12, 11.8.5 for CUDA 11) was just released, and it also causes some build issues for RAPIDS libraries: rapidsai/cuvs#445 (comment)

To unblock CI across RAPIDS, this proposes **temporarily** switching to ceilings on the `cuda-python` dependency here.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #543
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this pull request Nov 7, 2024
Follow-up to #17253

Contributes to rapidsai/build-planning#116

That PR used `!=` requirements to skip a particular version of `cuda-python` that `cudf` and `pylibcudf` were incompatible with. A newer version of `cuda-python` (12.6.2 for CUDA 12, 11.8.5 for CUDA 11) was just released, and it also causes some build issues for RAPIDS libraries: rapidsai/cuvs#445 (comment)

To unblock CI across RAPIDS, this proposes **temporarily** switching to ceilings on the `cuda-python` dependency here.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Bradley Dice (https://github.com/bdice)

URL: #17264
@jameslamb
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 2d4afb5 into rapidsai:branch-24.12 Nov 7, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cpp non-breaking Introduces a non-breaking change Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants