Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UMAP issues with large inputs #6245

Open
wants to merge 8 commits into
base: branch-25.02
Choose a base branch
from
Open

Fix UMAP issues with large inputs #6245

wants to merge 8 commits into from

Conversation

viclafargue
Copy link
Contributor

Answers #6204

@viclafargue viclafargue requested a review from a team as a code owner January 22, 2025 13:29
@viclafargue viclafargue requested review from bdice and lowener January 22, 2025 13:29
@viclafargue viclafargue added bug Something isn't working non-breaking Non-breaking change labels Jan 22, 2025
@viclafargue viclafargue mentioned this pull request Jan 22, 2025
Open
wphicks
wphicks requested changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Let's just make sure to IWYU for the new uses of uint64_t. Using C++ types (std::uint64_t) in our non-CUDA code would be a bonus, but it shouldn't block merge. I've also called out some spots where we could use uniform initialization syntax rather than a bare cast.

cpp/include/cuml/common/callback.hpp Outdated Show resolved Hide resolved
cpp/include/cuml/manifold/common.hpp Show resolved Hide resolved
cpp/src/umap/fuzzy_simpl_set/naive.cuh Outdated Show resolved Hide resolved
cpp/src/tsne/tsne_runner.cuh Outdated Show resolved Hide resolved
cpp/src/umap/fuzzy_simpl_set/naive.cuh Outdated Show resolved Hide resolved
cpp/src/umap/knn_graph/algo.cuh Outdated Show resolved Hide resolved
cpp/src/umap/simpl_set_embed/algo.cuh Show resolved Hide resolved
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 23, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@wphicks
Copy link
Contributor

wphicks commented Jan 23, 2025

@viclafargue That last commit was unsigned. Could you sign it and push that up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wphicks wphicks wphicks approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cuml-cpp-codeowners

@lowener lowener Awaiting requested review from lowener lowener is a code owner automatically assigned from rapidsai/cuml-cpp-codeowners

Assignees
No one assigned
Labels
bug Something isn't working CUDA/C++ non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viclafargue @wphicks