Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cpp/test to cpp/tests. #6237

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 18, 2025

Renames test directories to tests for alignment with the rest of RAPIDS.

See also: rapidsai/build-planning#140

@bdice bdice requested review from a team as code owners January 18, 2025 21:20
@dantegd dantegd changed the title Rename test to tests. Rename cpp/test to cpp/tests. Jan 23, 2025
@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 24, 2025
@vyasr
Copy link
Contributor

vyasr commented Jan 24, 2025

/merge

@bdice
Copy link
Contributor Author

bdice commented Jan 24, 2025

Another one of the strange cuda-gdb errors:

  File "/__w/cuml/cuml/python/cuml/cuml/tests/test_no_cuinit.py", line 77, in test_cuml_import_no_cuinit
    assert output.returncode == 0
AssertionError: assert 127 == 0
 +  where 127 = CompletedProcess(args=['/usr/local/cuda/bin/cuda-gdb', '-x', '-', '--args', '/pyenv/versions/3.10.16/bin/python', '-c'...rror while loading shared libraries: libpython3.9.so.1.0: cannot open shared object file: No such file or directory\n').returncode
----------------------------- Captured stdout call -----------------------------
Command output:

*** STDOUT ***

*** STDERR ***
/usr/local/cuda/bin/cuda-gdb-python3.9-tui: error while loading shared libraries: libpython3.9.so.1.0: cannot open shared object file: No such file or directory

@rapids-bot rapids-bot bot merged commit c262f1f into rapidsai:branch-25.02 Jan 24, 2025
67 checks passed
@vyasr
Copy link
Contributor

vyasr commented Jan 24, 2025

Until we can get that to repro on a given runner I've sort of given up on it for now :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants