Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Use stable 1.0.0 version of Treelite #3394

Merged
merged 7 commits into from
Jan 30, 2021
Merged

[REVIEW] Use stable 1.0.0 version of Treelite #3394

merged 7 commits into from
Jan 30, 2021

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Jan 21, 2021 •
edited
Loading

The stable 1.0.0 version of Treelite is virtually identical to the 1.0.0 RC1 version. Using 1.0.0rc1|1.0.0 so that the CI doesn't break until rapidsai/integration#210 is merged.

@hcho3 hcho3 requested a review from a team as a code owner January 21, 2021 14:10
@github-actions github-actions bot added the Ops label Jan 21, 2021
@hcho3 hcho3 added conda conda issue non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jan 21, 2021
@ajschmidt8
Copy link
Member

@hcho3, can you use the procedure outlined below to ensure that CI passes with the new treelite vesion? If it does, then we know we can safely merge the integration PR without causing issues.

https://docs.rapids.ai/maintainers/depmgmt/#testing-a-dependency

@JohnZed JohnZed self-assigned this Jan 21, 2021
@codecov-io
Copy link

codecov-io commented Jan 21, 2021 •
edited
Loading

Codecov Report

Merging #3394 (96b832b) into branch-0.18 (550121b) will increase coverage by 0.17%.
The diff coverage is 85.19%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #3394      +/-   ##
===============================================
+ Coverage        71.48%   71.66%   +0.17%     
===============================================
  Files              207      210       +3     
  Lines            16748    16945     +197     
===============================================
+ Hits             11973    12144     +171     
- Misses            4775     4801      +26
Impacted Files Coverage Δ
python/cuml/decomposition/incremental_pca.py 94.70% <ø> (ø)
python/cuml/dask/ensemble/base.py 19.69% <30.43%> (+0.36%) ⬆️
python/cuml/dask/cluster/kmeans.py 54.00% <33.33%> (ø)
python/cuml/ensemble/randomforestregressor.pyx 70.83% <44.44%> (ø)
python/cuml/dask/decomposition/base.py 39.53% <50.00%> (ø)
...ython/cuml/dask/ensemble/randomforestclassifier.py 30.00% <50.00%> (+0.51%) ⬆️
python/cuml/dask/ensemble/randomforestregressor.py 35.08% <50.00%> (+0.54%) ⬆️
python/cuml/dask/linear_model/linear_regression.py 59.09% <50.00%> (ø)
python/cuml/dask/linear_model/ridge.py 50.00% <50.00%> (ø)
...ython/cuml/dask/neighbors/kneighbors_classifier.py 22.33% <50.00%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c403f83...96b832b. Read the comment docs.

@hcho3 hcho3 added the 5 - Merge After Dependencies Depends on another PR: do not merge out of order label Jan 22, 2021
@hcho3
Copy link
Contributor Author

hcho3 commented Jan 22, 2021

This PR should not be merged until rapidsai/integration#210 is merged.

@hcho3
Copy link
Contributor Author

hcho3 commented Jan 22, 2021

rerun tests

1 similar comment
@hcho3
Copy link
Contributor Author

hcho3 commented Jan 22, 2021

rerun tests

@hcho3 hcho3 mentioned this pull request Jan 23, 2021
Merged
@hcho3 hcho3 added 3 - Ready for Review Ready for review by team and removed 5 - Merge After Dependencies Depends on another PR: do not merge out of order labels Jan 26, 2021
@hcho3
Copy link
Contributor Author

hcho3 commented Jan 26, 2021

Rerun tests

@hcho3
Copy link
Contributor Author

hcho3 commented Jan 26, 2021

@ajschmidt8 @JohnZed Now that rapidsai/integration#210 is merged, can I get around round of review?

@hcho3 hcho3 changed the title Use stable 1.0.0 version of Treelite [REVIEW] Use stable 1.0.0 version of Treelite Jan 27, 2021
@hcho3
Copy link
Contributor Author

hcho3 commented Jan 28, 2021

@gpucibot merge

@hcho3
Copy link
Contributor Author

hcho3 commented Jan 28, 2021 •
edited
Loading

@JohnZed Can we merge this now? The 0.18 release should depend on the stable version of Treelite.

@hcho3 hcho3 added 5 - Merge After Dependencies Depends on another PR: do not merge out of order and removed 3 - Ready for Review Ready for review by team labels Jan 28, 2021
@hcho3 hcho3 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 5 - Merge After Dependencies Depends on another PR: do not merge out of order labels Jan 28, 2021
@JohnZed
Copy link
Contributor

JohnZed commented Jan 30, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a22681c into rapidsai:branch-0.18 Jan 30, 2021
@hcho3 hcho3 deleted the use_stable_treelite branch January 30, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees

@JohnZed JohnZed

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge conda conda issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hcho3 @ajschmidt8 @codecov-io @JohnZed