-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DBG] Add RC ucx-py to conda recipe #1388
Conversation
@jakirkham, Dante & I are trying to integrate the current RC of ucx-py conda package into our build for 0.11 but we are struggling to find a good way to represent the labels in CI. |
@@ -41,6 +41,7 @@ requirements: | |||
- libcumlprims {{ minor_version }} | |||
- cupy>=6.5,<7.0 | |||
- nccl 2.4.* | |||
- conda-forge/label/rc_ucx::ucx-py=0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the channel needs to be added outside the recipe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking this too, just because I've seen it done that way in our conda enviornment files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conda-forge is outside the recipe, and we've used labels like these in the past:
- rapidsai/label/cuda9.2::cupy>=6* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not aware of conda-build supporting this syntax in recipes (though agree it would be useful). In fact there is an open issue ( conda/conda-build#532 ). Environment files are a different story.
Or at least it needs to be in the install and build commands that are called. Though the .condarc
would be better if that is a reasonable option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakirkham, are we still aiming to cut an official ucx-py conda-forge release for RAPIDS 0.11?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the schedules align, we might just be able to run with the official conda-forge version rather than using the rc labels. Or does this seem like it's side-stepping the problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's more likely we have a catch-22. 😅 Namely we want a proper release from upstream, but we've also identified a few more fixes needed as a result of trying it.
IMHO the sooner we can test the package here the better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cjnolet I don't think it would be a big issue to add the channel to the .condarc
, it is here if I'm not mistaken: https://github.com/rapidsai/gpuci-build-environment/blob/master/.condarc If both you and @jakirkham agree to add the RC package before or just after the issues with cuml.dask are resolved, we can just move to push for it being added to the condarc.
Adding this #1444. |
No description provided.