Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct defect found in DLFW testing #4021

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

ChuckHastings
Copy link
Collaborator

In MG tests, we had 2 different coding approaches, and one of the paths had a defect.

This makes all of the coding consistent and corrects the bug.

@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 27, 2023
@ChuckHastings ChuckHastings marked this pull request as ready for review November 27, 2023 21:10
@ChuckHastings ChuckHastings requested a review from a team as a code owner November 27, 2023 21:10
@ChuckHastings ChuckHastings self-assigned this Nov 27, 2023
@ChuckHastings ChuckHastings added this to the 23.12 milestone Nov 27, 2023
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChuckHastings
Copy link
Collaborator Author

/merge

@rapids-bot rapids-bot bot merged commit 1e446c4 into rapidsai:branch-23.12 Nov 28, 2023
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants