Fix rolling(min_periods=) with int and null data with mode.pandas_compat #17822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
bug
vyasr
approved these changes
Jan 24, 2025
| @pytest.mark.parametrize("klass", ["DataFrame", "Series"]) | ||
| def test_pandas_compat_int_nan_min_periods(klass): | ||
| data = [None, 1, 2, None, 4, 6, 11] | ||
| with cudf.option_context("mode.pandas_compatible", True): |
There was a problem hiding this comment.
Do we need to test the False case, or is that already handled in another test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #17786
Checklist