Resolve race-condition in disable_module_accelerator
#17811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
bug
github-actions
bot
added
Python
mroeschke
reviewed
Jan 24, 2025
| saved = self._use_fast_lib | ||
| self._use_fast_lib = False | ||
| try: | ||
| yield |
There was a problem hiding this comment.
Might be a dumb question Is it possible for self._use_fast_lib to be modified during this yield statement?
There was a problem hiding this comment.
Making this move seems to be also bringing back the race-condition.
mroeschke
reviewed
Jan 24, 2025
| @@ -613,7 +616,7 @@ def disable_module_accelerator() -> contextlib.ExitStack: | |||
| """ | |||
| Temporarily disable any module acceleration. | |||
| """ | |||
| with contextlib.ExitStack() as stack: | |||
| with ImportLock(), contextlib.ExitStack() as stack: | |||
There was a problem hiding this comment.
Nit: Is it ok if we call stack.enter_context(ImportLock()) after this line?
There was a problem hiding this comment.
I tried this change too and the race-condition seems to be coming back.
Note: I tried both suggestions separately and together, all three combinations result in branch-25.02 behavior i.e., a race condition.
3 tasks
|
/merge |
rapids-bot
bot
merged commit 133e0c8
into
rapidsai:branch-25.02
105 of 107 checks passed
galipremsagar
added
5 - Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #17775
This PR fixes a race condition that arises when
disable_module_acceleratoris used in a multi-threaded setting.Checklist