Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cudf._lib.string_udf work with pylibcudf Columns instead of cudf._lib Columns #17715

Open
wants to merge 1 commit into
base: branch-25.02
Choose a base branch
from
Open

Make cudf._lib.string_udf work with pylibcudf Columns instead of cudf._lib Columns #17715

wants to merge 1 commit into from
+26 −16

Conversation

mroeschke
Copy link
Contributor

Description

With the possibility of the cudf._lib.Column being refactored (possibly to a pure Python implementation), this PR makes the string_udf routines dependent on pylibcudf instead of the the cudf classic Cython based Column

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 10, 2025
@mroeschke mroeschke self-assigned this Jan 10, 2025
@mroeschke mroeschke requested a review from a team as a code owner January 10, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

At least 1 approving review is required to merge this pull request.

Assignees

@mroeschke mroeschke

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mroeschke