Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special orc test data: timestamp interspersed with null values #17713

Merged

Conversation

kingcrimsontianyu
Copy link
Contributor

@kingcrimsontianyu kingcrimsontianyu commented Jan 10, 2025

This PR adds small-size synthesized TIMESTAMP data containing null values that are able to reproduce the ORC decoding bug reported by #17155 on cuDF v24.12.00. This PR confirms that the fix introduced in #17570 for the upcoming cuDF v25.02 works properly on these special data.

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link

copy-pr-bot bot commented Jan 10, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Jan 10, 2025
@kingcrimsontianyu kingcrimsontianyu added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 10, 2025
@kingcrimsontianyu
Copy link
Contributor Author

/ok to test

@kingcrimsontianyu kingcrimsontianyu changed the title Add special orc test data: timestamp interspersed with null values. U… Add special orc test data: timestamp interspersed with null values Jan 10, 2025
@kingcrimsontianyu kingcrimsontianyu marked this pull request as ready for review January 10, 2025 14:19
@kingcrimsontianyu kingcrimsontianyu requested a review from a team as a code owner January 10, 2025 14:19
@kingcrimsontianyu
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit dc2a75c into rapidsai:branch-25.02 Jan 10, 2025
122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants