Enforce schema for partial tables in multi-source multi-batch JSON reader #17708
+137
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
shrshi
added
bug
3 tasks
|
/ok to test |
|
/ok to test |
|
/ok to test |
vuule
requested changes
Jan 18, 2025
Comment on lines
139
to
153
| std::string json_string_b1 = R"( | ||
| { "a": { "y" : 6}, "b" : [1, 2, 3], "c": 11 } | ||
| { "a": { "y" : 6}, "b" : [4, 5 ], "c": 12 } | ||
| { "a": { "y" : 6}, "b" : [6 ], "c": 13 } | ||
| { "a": { "y" : 6}, "b" : [7 ], "c": 14 })"; | ||
| std::string json_string_b2 = R"( | ||
| { "a": { "y" : 6}, "c": 11 } | ||
| { "a": { "y" : 6}, "b" : [4, 5 ], "c": 12 } | ||
| { "a": { "y" : 6}, "b" : [6 ], "c": 13 } | ||
| { "a": { "y" : 6}, "b" : [7 ], "c": 14 })"; | ||
| std::string json_string_b3 = R"( | ||
| { "a": { "y" : 6}} | ||
| { "a": { "y" : 6}, "b" : [4, 5 ], "c": 12 } | ||
| { "a": { "y" : 6}, "b" : [6 ], "c": 13 } | ||
| { "a": { "y" : 6}, "b" : [7 ], "c": 14 })"; |
There was a problem hiding this comment.
how are the schemas different between these three?
I suspect that json_string_b1 is "a","b","c" json_string_b2 is "a","c","b", but I can't tell what json_string_b3 leads to.
A comment on what the test case here is would be great.
There was a problem hiding this comment.
The column ordering is different across batches - we set the batch size to the size of first string json_string_b1. And we enforce the same ordering on batches 2 and 3.
|
/ok to test |
vuule
approved these changes
Jan 23, 2025
Co-authored-by: Vukasin Milovanovic <[email protected]>
karthikeyann
approved these changes
Jan 23, 2025
|
/ok to test |
pmattione-nvidia
approved these changes
Jan 24, 2025
|
/ok to test |
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #17689
This PR resolves a bug in the multi-batch JSON reader, wherein the reader was throwing an error when the column schema for any two partial tables from different batches did not match. We now enforce the column ordering in the first partial table i.e. the table returned by the first batch in all succeeding batches.
The test added passes three string as three separate batches to the reader by setting the batch size to that of the first string.
Checklist