Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure pyarrow.Scalar to pylibcudf.Scalar is cached #17707

Open
wants to merge 3 commits into
base: branch-25.02
Choose a base branch
from
Open

Ensure pyarrow.Scalar to pylibcudf.Scalar is cached #17707

wants to merge 3 commits into from

Conversation

mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Jan 9, 2025 •
edited
Loading

Description

I realized in #17686 that this refactoring might have sidestepped the caching benefits in the prior cudf.Scalar usage. This PR introduces pa_scalar_to_plc_scalar which caches the pyarrow to pylibcudf conversion in that PR.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 9, 2025
@mroeschke mroeschke self-assigned this Jan 9, 2025
@mroeschke mroeschke requested a review from a team as a code owner January 9, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

At least 1 approving review is required to merge this pull request.

Assignees

@mroeschke mroeschke

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mroeschke