Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 3rd party license file in Conda packages #654

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Add 3rd party license file in Conda packages #654

merged 2 commits into from
Dec 11, 2023

Conversation

jakirkham
Copy link
Member

Previously only cuCIM's own license file was included in Conda packages. However the 3rd party license file was not included in Conda packages. This adds that license file as well. Also goes ahead and adds the 3rd party license file to both libcucim and cucim for good measure (even though it is a little redundant to add it to cucim given it depends on libcucim, which already has it)

@jakirkham jakirkham requested a review from a team as a code owner December 9, 2023 00:18
@jakirkham jakirkham added bug Something isn't working non-breaking Introduces a non-breaking change labels Dec 9, 2023
grlee77
grlee77 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@grlee77 grlee77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can potentially remove dockcross now that we are using RAPIDS containers for the wheel builds. We still have those files in the repository, though, so let's leave that for a separate follow-up.

@jakirkham
Copy link
Member Author

I guess we can potentially remove dockcross now that we are using RAPIDS containers for the wheel builds. We still have those files in the repository, though, so let's leave that for a separate follow-up.

Yep filed issue ( #655 ) recently to discuss

@jakirkham
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 87410cd into rapidsai:branch-24.02 Dec 11, 2023
39 checks passed
@jakirkham jakirkham deleted the add_lic_3rd_conda branch December 11, 2023 23:30
@jakirkham
Copy link
Member Author

Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grlee77 grlee77 grlee77 approved these changes

@raydouglass raydouglass raydouglass approved these changes

Assignees

@jakirkham jakirkham

Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakirkham @raydouglass @grlee77