-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inform setuptools
that Extensions
are included
#643
Inform setuptools
that Extensions
are included
#643
Conversation
Ensure `setuptools` knows our package has extension modules. Even though it is not totally obvious they are there.
a2506af
to
07e2ed2
Compare
This works! 🎉 Final name from CI:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, John. This looks good! I guess this may be preferable to renaming after the fact as in #644.
This reverts commit 12ec30b. Doing this because `wheel tags` adds an additional `Root-Is-Purelib` field to `*.dist-info/WHEEL` without removing the previous one, which causes the wheel to fail checks.
Turns out
So reviving this alternative approach and reverting the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To unblock the release, can we also add (or symlink) the license into python/cucim?
Running ln -s ../../LICENSE
in the python/cucim
directory should do it (unless we need the 3rd party license, I don't know, but symlink that one instead if needed).
Good catch. Went ahead and symlinked both and updated |
76ef188
to
e7f7d74
Compare
e7f7d74
to
96630be
Compare
Fixes #641
As
setuptools
/pip
/wheel
will mark our package as pure (even though we put an extension module into it), make sure it doesn't by informingsetuptools
thatExtensions
are contained within. This should ensure that are wheels include the Python minor version they were built for.